Xinha Discussion Forum

Well, you'd think that, but if we are modelling things on the way that Word et al work, that's exactly what they do (I think, at least in the OOWriter instance I'm looking at now).  You can see this simply by entering

fooo<hit enter>
bar

place the cursor in fooo somewhere and hit right align, you'll see that only that line aligns, because they are distinct paragraphs.  If on the other hand you do

fooo<hit shift-enter>
bar

and cursor into fooo and right align, you'll see both lines align because effectively they are the same paragraph.  It's plain crazy if you ask me.

Mmm, I really don't like that at all.  But as long as it's a plugin that does it I don't give a crap

Actually, can somebody who has MS Word handy confirm that it behaves in the same way?

If you get it working (or even partially working) I think this would be a [bold]very[/bold] popular addition to Xinha, particularly when we get some sort of "shielded" code happening.  I'd love to see the resulting plugin in the Xinha package.  If you want to do it in the Xinha subversion repository I'm happy to accommodate, just let me know.

All you need to do is override HTMLArea.prototype.getHTML() with your own function which
a) if your "helene" editor is currently displayed, returns the content from that
b) otherwise returns the content of the original getHTML..

I think something like this would work..

function HeleneEditor(editor)
{
  this.editor = editor;
  var helene = this;
  editor.getHTML_pre_helena = editor.getHTML;
  editor.getHTML = function() { return helene.getHTML(); }
}

HeleneEditor.prototype.getHTML = function() 
{
  if(this.isActive) return this.someContent; // whateever, pseudo code of course ;)
  return this.editor.getHTML_pre_helena();
}

Code+bugfixes are worth more than money

Hmmm.  Yes that's a good point.  It may work already, but if it doesn what we would need to do is insert a non-breaking-space ( ) into blank paragraphs (<p></p> or <p/>).  That would do the job (the   would create the "blank line" you are seeking).

Actually, thinking about it more, it might be better if <p></p> and  <p/> were converted to a <br/> in thier entirity, so as to avoid meaningless paragraphs like <p> </p>

ie..
<p>Blah</p>
<br/>
<p>Foo</p>

this would also give the desired effect I think.  We could also add a class to the <br/> so we can distinguish it from "explicit" breaks created by SHIFT-enter

<p>Blah</p>
<br class="xinha_implicit_break"/>
<p>Foo</p>

so if the developer wanted to remove those breaks they could using CSS (.xinha_implicit_break { display:none} would probably do it).

I think a simple check of the DOM when hitting enter (at the very last step, after enterparagraphs etc) would do that (getElementsByTagName('p') and check for childless ones that are not currently "focused", convert to breaks and add a class).

That said, setting textarea.value should work fine too. 

Check it out against a fresh copy of the nightly, I can't think of anything that would do that.

Yermo, perhaps you would like to look at including EFM as well (if the licence permits, I havn't looked at it), I think it's a quite popular plugin so would be good to have it there (particularly in the examples).

Yes if you havn't submitted a ticket please do.  Also if you could attach a screenshot illustrating the problem to the ticket.

There are a few things I'll point out here.

1. There was a bug in EnterParagraphs (that I think I introduced) that made enter effectivly do a double paragraph break.  This is the same bug that stopped lists from working properly.  It was fixed a while back.
2. P is the preferred markup because that's the way that word processors work,  hitting enter produces a new paragraph rather than a line break. The difference is that in html P creates a top/bottom margin.  In word etc it doesn't (at least, in OOWriter which I'm looking at right now), you can see this in say OOWriter or Word (havn't actually looked, but I guess) by typing some text, hit enter, type some more, then right align - only one of the texts will align, because they are separate paragraphs.  If you use shift-enter then both will align because they are the same paragraph.

Because of that, I think the best solution is for the developer implementing Xinha to just use CSS to style-out the margins of paragraphs defined within content that has been edited by Xinha.

I don't see how it would be a problem for the developer to do

<div class="fromxinha"><?php echo $stuffFromXinha ?></div>

and have CSS with

.fromxinha p { margin-top:0px; margin-bottom:0px }

and similarly

config.pageStyle ='p { margin-top:0px; margin-bottom:0px; }'

I don't see a reason for there to be code included into xinha to accomplish this, as long as what Xinha produces is wellformed HTML markup, the developer can use CSS to do whatever he/she wants with it.

Forms may or may not work for you   Please submit a ticket for this so we can look at it at some stage.

You may find it's better to use

  config.pageStyleSheets.push('/htmlarea/screen.css');

but please submit a ticket for this anyway.